Skip to content

Replace python command with python3 to compile binaryen on Linux again.#2281

Merged
kripken merged 5 commits intoWebAssembly:masterfrom
apoleon:master
Sep 13, 2019
Merged

Replace python command with python3 to compile binaryen on Linux again.#2281
kripken merged 5 commits intoWebAssembly:masterfrom
apoleon:master

Conversation

@apoleon
Copy link
Contributor

@apoleon apoleon commented Aug 3, 2019

This is the fix for #1691

@kripken
Copy link
Member

kripken commented Aug 5, 2019

Thanks @apoleon!

It looks like there is no python3 in that docker image, which is causing that error.

@trzecieu I think that's your image - is the lack of python3 intentional there? If so maybe we need to install it in our CI here.

@trzecieu
Copy link

trzecieu commented Aug 12, 2019

Hi @kripken, @apoleon it wasn't.
Hosted image is more like a base image that could be extended, but indeed as Emscripten has nice python3 support I will switch to it. Once it's done I will report it here.

@trzecieu
Copy link

Hi,
I've fixed my building scripts and added python3 to emscripten-slim images.

➜ docker run --rm -it trzeci/emscripten-slim python3 --version
Unable to find image 'trzeci/emscripten-slim:latest' locally
latest: Pulling from trzeci/emscripten-slim
9fc222b64b0a: Pull complete 
c83a77646c07: Pull complete 
5a0d43034d7b: Pull complete 
7c1ece14290e: Pull complete 
7b4816a5faa6: Pull complete 
7fc9b6a1940b: Pull complete 
53d18c007e95: Pull complete 
9d4e29476964: Pull complete 
c1ca614584e0: Pull complete 
Digest: sha256:98caf2d2e3cf644bc03e98a3ceefcd325c0a9806ceb78eb88711fe7d417dc945
Status: Downloaded newer image for trzeci/emscripten-slim:latest
Python 3.5.3

So that Emscripten Slim 1.38.34+ is shipped with python3 and python2. Still managed to have a total size of 170MB which is still sweet.
Sorry for inconvenience.

@sbc100
Copy link
Member

sbc100 commented Aug 30, 2019

So maybe if I retry the travis job it will pass now?

@trzecieu
Copy link

trzecieu commented Aug 30, 2019

It will fail as I didn't set in place sdk-incoming-64bit tag and I was focused on the tagged releases.
Let me take a look this evening what I can do to recover incoming image (it's pointing at some old version).
Alternatively tag can be switched from incoming to latest which is set to the latest tagged release of emscripten and it's compiled against emscripten-releases repo

@trzecieu
Copy link

Should work now:

➜ docker run --rm -it trzeci/emscripten-slim:sdk-incoming-64bit python3 --version
Python 3.5.3
➜ docker run --rm -it trzeci/emscripten:sdk-incoming-64bit python3 --version 
Python 3.5.3

@trzecieu
Copy link

Can it be re-triggered and tested?

@sbc100
Copy link
Member

sbc100 commented Sep 11, 2019

Restarted test

@kripken
Copy link
Member

kripken commented Sep 13, 2019

Looks good, thanks!

@kripken kripken merged commit 19bc69a into WebAssembly:master Sep 13, 2019
sbc100 added a commit that referenced this pull request Sep 21, 2019
Even though we do support python3 and if the python in your path
happens to be python3 that will work just fine, we also want to
continue to support those users who still only have python2 (i.e.
mac users who are relying on the default system python).

See emscripten-core/emsdk#356
sbc100 added a commit that referenced this pull request Sep 23, 2019
#2349)

Even though we do support python3 and if the python in your path
happens to be python3 that will work just fine, we also want to
continue to support those users who still only have python2 (i.e.
mac users who are relying on the default system python).

See emscripten-core/emsdk#356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants