Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename acces to access #209 #211

Conversation

denisvasilik
Copy link
Contributor

This pull request is part of issue #209.

@sunfishcode
Copy link
Member

This makes sense to me. There's evidence that people commonly spell this one access despite the POSIX spelling:

https://lore.kernel.org/patchwork/patch/1003891/
https://lore.kernel.org/patchwork/patch/1079508/
https://lkml.org/lkml/2019/5/27/185

Of course, WASI libc will need to continue to expose this as EACCES, because that is the POSIX name. So the primary effect of this name change will be to make the documentation more clear, but that seems worth it to me here.

@sunfishcode sunfishcode merged commit 445aeb7 into WebAssembly:master Feb 19, 2020
@sunfishcode
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants