Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename creat to create. #199

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

sunfishcode
Copy link
Member

Ken Thompson was once asked what he would do differently if he were
redesigning the UNIX system. His reply: "I'd spell creat with an e."

Ken Thompson was once asked what he would do differently if he were
redesigning the UNIX system. His reply: "I'd spell creat with an e."

 - https://en.wikiquote.org/wiki/Ken_Thompson#Quotes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha!

To be fair I think he as refering to the creat function not the O_CREAT flag.

If you are going to make this change why not also spell "exclusive" and "truncate" correctly too?

@sunfishcode
Copy link
Member Author

I'm ok either way there. We do have a lot of other abbreviations, like inval, isdir, and so on, so if you want, there are a lot more we could consider here. I think creat just feels especially gratuitous because it's only saving one letter. And Ken Thompson would seem to agree ;-).

Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 we could probably untruncate trunc and rename excl to exclusive too. they're the same length as directory.

@joshtriplett
Copy link
Contributor

👍

The "creat" abbreviation does need to exist in libc and similar libraries, to avoid gratuitously breaking compatibility. However, we don't need that abbreviation in the native syscall layer.

@sunfishcode
Copy link
Member Author

I think another factor here is something like an uncanny valley effect -- creat just looks like a typo rather than an abbreviation.

In any case, we seem to have consensus for renaming creat at least, so let's do it!

@sunfishcode sunfishcode merged commit d848cd8 into WebAssembly:master Jan 24, 2020
@sunfishcode sunfishcode deleted the creat branch January 24, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants