Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JDBC node #559

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Fix JDBC node #559

merged 2 commits into from
Apr 11, 2022

Conversation

demonray
Copy link
Contributor

@demonray demonray commented Apr 2, 2022

What is the purpose of the change

Fix JDBC node #549 #557 #542

Verifying this change

This change added tests and can be verified as follows:
Add JDBC node in workflow，then open it.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • Anything that affects deployment: no
  • The Core framework, i.e., AppConn, Orchestrator, ApiService.: no

Documentation

  • Does this pull request introduce a new feature? no

@demonray demonray requested a review from wushengyeyouya April 2, 2022 06:21
@demonray demonray self-assigned this Apr 2, 2022
wushengyeyouya
wushengyeyouya approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@wushengyeyouya wushengyeyouya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wushengyeyouya wushengyeyouya merged commit a6c0461 into WeBankFinTech:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wushengyeyouya wushengyeyouya wushengyeyouya approved these changes

Assignees

@demonray demonray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demonray @wushengyeyouya