Dev 0.9.1 #284

det101 · 2021-02-24T06:27:54Z

Version 0.9.1 code, to achieve user to create modules

Adamyuanyuan · 2021-02-24T06:31:28Z

thanks

Adamyuanyuan

thanks

Adamyuanyuan

Pay attention to security compliance, hide IP, password, etc

Adamyuanyuan · 2021-02-24T06:40:21Z

dss-server/src/main/resources/linkis.properties

@@ -17,11 +17,11 @@

 wds.linkis.test.mode=true

-wds.linkis.server.mybatis.datasource.url=jdbc:mysql://127.0.0.1:3306/
+wds.linkis.server.mybatis.datasource.url=jdbc:mysql://192.168.10.180:3306/dss


Hide IP, password, etc

xj2jx

Thank you very much for your cubmits.
Some suggestions for modification are pended. The biggest problem is the design of Command and AbsComand. I feel that the interface in Command is not universal.

xj2jx · 2021-03-04T06:25:12Z

dss-application/src/main/java/com/webank/wedatasphere/dss/application/entity/DSSUser.java

+    //增加是否超级用户表示 0-不是超级用户 1-是超级用户
+    private int isSuperUser = 0;
+
+    public int getIsSuperUser() {
+        return isSuperUser;
+    }
+    public void setIsSuperUser(int isSuperUser) {
+        this.isSuperUser = isSuperUser;
+    }


To keep the code style, isSupperUser should use Boolean

xj2jx · 2021-03-04T07:41:19Z

...application/src/main/java/com/webank/wedatasphere/dss/application/util/ApplicationUtils.java

+    public static void main(String[] args) throws Exception {
+//        System.out.println(redirectUrlFormat("http://127.0..0.1:8090/qualitis/api/v1/redirect","http://127.0..0.1:8090/#/projects/list?id={projectId}&flow=true"));
+
+        WorkSpacePath workSpacePath = new WorkSpacePath();
+        workSpacePath.setWorkspaceRootPath("/");
+        System.out.println(convertToMap(workSpacePath));


should remove test code

xj2jx · 2021-03-04T07:56:11Z

dss-application/src/main/java/com/webank/wedatasphere/dss/application/entity/DSSUser.java

@@ -25,6 +25,15 @@
    private String username;
    private String name;
    private Boolean isFirstLogin;
+    //增加是否超级用户表示 0-不是超级用户 1-是超级用户


comment need use English

xj2jx · 2021-03-04T08:03:52Z

...ion/src/main/java/com/webank/wedatasphere/dss/application/restful/ApplicationRestfulApi.java

+        //是否超级用户登录
+        if(username.equals(superUserName)){
+            dssUser.setIsSuperUser(1);
+        }else{
+            dssUser.setIsSuperUser(0);


Avoid using magic values, use Boolean can avoid it

xj2jx · 2021-03-04T08:06:39Z

...a/com/webank/wedatasphere/dss/appjoint/scheduler/azkaban/service/AzkabanSecurityService.java

+        LOGGER.info("开始读取用户token文件");
+        Properties properties = new Properties();
+        try {
+            properties.load(AzkabanSecurityService.class.getClassLoader().getResourceAsStream(AzkabanConstant.TOKEN_FILE_NAME));
+            userToken = properties;
+        } catch (IOException e) {
+            LOGGER.error("读取文件失败:",e);


can't print the Chinese log only, but can only print the English log.

xj2jx · 2021-03-04T09:32:28Z

...r-manager/src/main/java/com/webank/wedatasphpere/dss/user/service/impl/MetastoreCommand.java

+                String path = DSSUserManagerConfig.METASTORE_HDFS_PATH + "/"+dbName+".db";
+                bashCommand = getResource(DSSUserManagerConfig.METASTORE_SCRIPT_PAHT);
+                args = new String[]{ userName,dbName,path,
+                        DSSUserManagerConfig.KERBEROS_REALM,DSSUserManagerConfig.KERBEROS_ADMIN,DSSUserManagerConfig.KERBEROS_KEYTAB_PATH,DSSUserManagerConfig.KEBBEROS_ENABLE_SWITCH};


if cluster not open kerberos, maybe this code cann't running, please check it

We have used parameters: DSSUserManagerConfig.KERBEROS_ ENABLE_ Switch controls it

xj2jx · 2021-03-04T09:35:45Z

...r-manager/src/main/java/com/webank/wedatasphpere/dss/user/service/impl/SchedulisCommand.java

+        RestTemplate restTemplate = new RestTemplate();
+        String schedulisUrl = DSSUserManagerConfig.SCHEDULER_ADDRESS;
+        String url = new StringBuilder().append(schedulisUrl)
+            .append("/luban/schedule/system")


this url suggest to modify, make the url configurable

Thank you. It has been revised

xj2jx · 2021-03-04T09:47:29Z

dss-user-manager/src/main/java/com/webank/wedatasphpere/dss/user/conf/DSSUserManagerConfig.java

@@ -0,0 +1,39 @@
+package com.webank.wedatasphpere.dss.user.conf;


all user-manager model file need to add License.

/*

Copyright 2019 WeBank

Licensed under the Apache License, Version 2.0 (the "License");

you may not use this file except in compliance with the License.

You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software

distributed under the License is distributed on an "AS IS" BASIS,

WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

See the License for the specific language governing permissions and

limitations under the License.

*/

xj2jx · 2021-03-04T09:51:39Z

dss-user-manager/src/main/java/com/webank/wedatasphpere/dss/user/service/AbsCommand.java

+    @Override
+    public String authorization(AuthorizationBody body) throws IOException,DocumentException, Exception { return Command.SUCCESS; }
+    public String toMessage(String msg) {
+        return this.getClass().getSimpleName() + "模块开始执行："+ msg;


please replace Chinese by English

Thank you. It has been revised

xj2jx · 2021-03-04T09:52:16Z

dss-server/src/main/java/com/webank/wedatasphere/dss/server/constant/DSSServerConstant.java

@@ -28,4 +28,6 @@
    public static final String EMVEDDEDFLOWID = "\"embeddedFlowId\":";
    public static final String VERSION_FORMAT = "%06d";
    public static final String VERSION_PREFIX = "v";
+    public static final String SUPER_USER_LOGIN_ERROR = "没有创建权限，请使用超级用户登录";


please replace Chinese by English

demonray

Good job!

… be configured

documentation

Stream close

Dev 0.9.1

Adamyuanyuan approved these changes Feb 24, 2021

View reviewed changes

Adamyuanyuan reviewed Feb 24, 2021

View reviewed changes

xj2jx reviewed Mar 4, 2021

View reviewed changes

wushengyeyouya requested a review from demonray March 18, 2021 07:45

demonray approved these changes Mar 18, 2021

View reviewed changes

det101 and others added 22 commits March 23, 2021 19:15

the base code of user authorization

c5cd5c1

the code of unit test

e448f44

Workspace path modification initialization

34076ef

Improve the basic code, add front-end code local debugging through

76ca3d1

Workspace path modification initialization

6ae64a7

User management path authorization changes

b8df8de

User management path authorization modification - add userPath

b5f0161

The Metastore interface was added, and the Metastore service needs to…

a5ca40d

… be configured

add comment

6d484e6

New Hostname auto-fetch with Realm configuration definition

7ecd4f5

Added keytab key generation function

cbc65e4

entry of super admin

f233a2a

Create a new Azkaban account & refactor code

13e1be9

Added DSS and Zakaban configuration to the page

18744be

Create an LDAP account initialization

4fd13d3

adjust the format

668dc8f

Create an LDAP account initialization

b4d4339

Open dispatch account

d61591d

Open dispatch account

5110a38

fix conflict

e122a2b

Fixed Azkaban opening issues

0187ca2

Complex path issues and scripting compatibility

a3bbb77

det101 and others added 28 commits March 23, 2021 19:20

Add the path to the fetch script

c5a04cf

Improved Kerberos, Metastore scripts and code, and added usage

0c4078a

documentation

Create a space where all success is success

ea889de

Add super account permissions

93cdc0e

ldap optimize

59133bc

create linux user

42fd799

save

bdacec0

Create user add server Settings

3882797

up

5a0256c

Add a password strength check

ad71ef3

script modification

5a40cf8

Add a password strength check

c624c0a

Fixed missing packaging issues

9635189

Modify version number

56e89b1

Create user to keep user filled content to local

4129a7e

fix builder error

b8b9237

delete password

16c7e06

clear dss-server password

e51f1d0

Optimize account opening script

9ac837c

Optimize shell scripts for one click account function

4c84e32

modify file the DSSUserManagerConfig file

76af358

add notes in English

cb44216

better data type

935f560

The default configuration

48331ae

review fix

64bb8fe

Stream close

change class name

c358a81

docs update

10a5b82

add License

4a3164e

wushengyeyouya merged commit cd4e7c9 into WeBankFinTech:dev-0.9.1 Mar 24, 2021

htyredc pushed a commit that referenced this pull request Nov 28, 2024

Merge pull request #284 from kingsGlory/dev-0.9.1

92f1fb7

Dev 0.9.1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev 0.9.1 #284

Dev 0.9.1 #284

det101 commented Feb 24, 2021

Adamyuanyuan commented Feb 24, 2021

Adamyuanyuan left a comment

Adamyuanyuan left a comment

Adamyuanyuan Feb 24, 2021

xj2jx left a comment

xj2jx Mar 4, 2021

xj2jx Mar 4, 2021

xj2jx Mar 4, 2021

xj2jx Mar 4, 2021

xj2jx Mar 4, 2021

xj2jx Mar 4, 2021

HanTang1 Mar 5, 2021

xj2jx Mar 4, 2021

HanTang1 Mar 5, 2021

xj2jx Mar 4, 2021

xj2jx Mar 4, 2021

HanTang1 Mar 5, 2021

xj2jx Mar 4, 2021

demonray left a comment

		@@ -0,0 +1,39 @@
		package com.webank.wedatasphpere.dss.user.conf;

Dev 0.9.1 #284

Dev 0.9.1 #284

Conversation

det101 commented Feb 24, 2021

Adamyuanyuan commented Feb 24, 2021

Adamyuanyuan left a comment

Choose a reason for hiding this comment

Adamyuanyuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xj2jx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

demonray left a comment

Choose a reason for hiding this comment