Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Ritual of the Feathered Earth to BM2. #1492

Merged
merged 10 commits into from
Feb 1, 2019

Conversation

keraldi
Copy link
Collaborator

@keraldi keraldi commented Dec 31, 2018

No description provided.

@TehNut
Copy link
Collaborator

TehNut commented Jan 20, 2019

I feel like a more user-friendly implementation of this would be to handle the actual effect in a damage event and cancelling it if it's fall damage while they're in range.

This current implementation is just constantly setting fall damage to 0 every second, even for entities which aren't moving, which just seems wrong.

@keraldi
Copy link
Collaborator Author

keraldi commented Jan 23, 2019

Done.

@@ -2,7 +2,7 @@ mod_name=BloodMagic
package_group=com.wayoftime.bloodmagic
mod_version=2.3.3
mc_version=1.12.2
forge_version=14.23.2.2611
forge_version=14.23.5.2768
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad.

@TehNut TehNut merged commit 865968a into WayofTime:1.12 Feb 1, 2019
@keraldi keraldi deleted the FeatheredEarthRitual branch February 1, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants