Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compound options: support default values #62

Merged
merged 5 commits into from
Jul 27, 2023
Merged

compound options: support default values #62

merged 5 commits into from
Jul 27, 2023

Conversation

NamorNiradnug
Copy link
Contributor

@NamorNiradnug NamorNiradnug commented Jul 17, 2023 •
edited
Loading

The feature has been discussed here.

TODO:

  • tests

ammen99
ammen99 requested changes Jul 26, 2023
View reviewed changes
@NamorNiradnug NamorNiradnug requested a review from ammen99 July 26, 2023 22:49
ammen99
ammen99 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks ;)

@ammen99 ammen99 merged commit ba19edd into WayfireWM:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NamorNiradnug @ammen99