-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wf-panel does not lose keyboard focus when closing menu #2118
Labels
Comments
That comment which says rearranging the layers will update cursor focus seems quite outdated. We probably need to simply refocus at the end of the function, if the interactivity has changed. We already have one such check, so probably it should just be extended to handle more cases. |
Seems like a duplicate of #2047. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I found it nice to have the new feature to open / close the menu with a keyboard shortcut (from #2097), but I found that when closing the menu with the keyboard, the panel retains the keyboard focus. To me, the natural behavior would be that the last focused app gets back the focus. I feel that this is actually the intended behavior, since wf-panel sends a
zwlr_layer_surface_v1#40.set_keyboard_interactivity(0)
request when the menu is closed. Also here, it is indicated that a refocus might happen as a consequence of changing keyboard-interactivity, but thearrange_layers()
function does not seem to handle focus changes.To Reproduce
Steps to reproduce the behavior:
wayfire-shell/toggle_menu
).Expected behavior
The last focused view gets back the keyboard focus.
Wayfire version
latest git (9c9630d)
The text was updated successfully, but these errors were encountered: