feat: linux-musl target,docker image,add rc4-md5 cipher #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add rc4-md5 cipher
Itsusinn
reviewed
Aug 24, 2024
Itsusinn
reviewed
Aug 24, 2024
Itsusinn
reviewed
Aug 25, 2024
Itsusinn
reviewed
Aug 25, 2024
ibigbug
reviewed
Aug 25, 2024
Itsusinn
previously approved these changes
Aug 25, 2024
Itsusinn
reviewed
Aug 25, 2024
.github/workflows/ci.yml
Outdated
| push: true | ||
| tags: ${{ env.TAG_VERSION }},${{ env.TAG_LATEST }} | ||
|
|
||
| - name: Delete all images from package without tags |
There was a problem hiding this comment.
Remove this if we only build images on release
|
|
|
The latest docker builds use |
|
For docker hub or GitHub docker registry? |
Currently only for GitHub image registry (ghcr.io), do I need to support docker.io? |
|
nah ghcr is good enough for now |
ibigbug
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
None
💡 Background and solution
📝 Changelog
Tweaked CI build to add x86_64-unknown-linux-musl target
Added docker image based on x86_64-unknown-linux-musl package.
Added rc4-md5 cipher parsing.
☑️ Self-Check before Merge
You need to add two action secrets: DOCKER_USERNAME and DOCKER_PASSWORD.