build: upgrade tuic-core to v1.8.4#1431
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPins ChangesDependency and TUIC updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Bbr: quinn-congestions BbrConfig (quinn-congestions) - Bbr3: quinn built-in Bbr3Config - keep Bbr as default
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@clash-lib/src/proxy/tuic/mod.rs`:
- Around line 14-18: The tuic_core::quinn use block is misformatted for
rustfmt/CI: reorder and reflow the imported symbols (QuinnConfig, QuinnEndpoint,
EndpointConfig, TokioRuntime, QuinnTransportConfig, VarInt, bbr::BbrConfig,
congestion::{Bbr3Config, CubicConfig, NewRenoConfig},
crypto::rustls::QuicClientConfig) to follow rustfmt and ASCII case-sensitive
import ordering (upper-case before lower-case) and then run cargo +nightly fmt
--all to apply the correct formatting; ensure the multi-line use statement is
wrapped and aligned per rustfmt so CI fmt check passes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 09ca4394-9901-443a-8a70-b521a4028c4f
📒 Files selected for processing (2)
clash-lib/src/proxy/tuic/mod.rsclash-lib/src/proxy/tuic/types.rs
Contributor
📊 Proxy Throughput ResultsShadowsocks
Trojan
VMess
VLESS
SOCKS5
AnyTLS
Hysteria2
TUIC
ShadowQUIC
SSH
Netem Tests (50 ms delay, 1% packet loss)Shadowsocks
Trojan
Hysteria2
TUIC
ShadowQUIC
Ran 34 variant(s) in parallel; each direction transfers the full payload. 🖥️ Test Environment
📎 View full workflow run and download artifacts Full test logDownload the |
ibigbug
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
tuic-corefrom branch-based dependency (build/tuic) tov1.8.4tag.Changes in
Itsusinn/tuicv1.8.4:tuic_core::quinnquinn-congestionsdependency and feature flags (quinn/rustls-ring,quinn/rustls-aws-lc-rs,runtime-tokio)Congestion controller update:
bbr: now usesBbrConfigfromquinn-congestions(instead of incorrectly using built-inBbr3Config)bbr3: new option, uses Quinn built-inBbr3ConfigTested:
cargo buildpassesSummary by CodeRabbit