Skip to content

fix: shadowquic udp proxy#1412

Merged
ibigbug merged 2 commits into
Watfaq:masterfrom
spongebob888:fix-sq
May 15, 2026
Merged

fix: shadowquic udp proxy#1412
ibigbug merged 2 commits into
Watfaq:masterfrom
spongebob888:fix-sq

Conversation

@spongebob888

@spongebob888 spongebob888 commented May 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Type

  • Bug fix
  • New feature
  • Refactoring / cleanup
  • Other

Checklist

  • Tests added or not needed
  • Docs updated or not needed

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Fixed address mapping issue in shadowquic proxy connections.
  • Chores

    • Updated shadowquic library dependency from version 0.3.4 to 0.3.5 and modified its dependency source.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates the shadowquic dependency from version 0.3.4 to 0.3.5, removes git-based source pinning to use a registry version, cleans up the feature flag by removing an unused subfeature, and corrects a src/dst address swap bug in the UDP session wrapper.

Changes

Shadowquic integration fixes

Layer / File(s) Summary
Shadowquic dependency upgrade
clash-lib/Cargo.toml
Shadowquic dependency is updated from 0.3.4 to 0.3.5 and the git+rev source pinning is removed to allow registry-based resolution.
Feature cleanup and address mapping fix
clash-lib/Cargo.toml, clash-lib/src/proxy/shadowquic/compat.rs
The shadowquic feature declaration removes the shadowquic?/sunnyquic-iroh-quinn subfeature dependency. UdpSessionWrapper's poll_next corrects the address mapping by assigning received address to src_addr and stored address to dst_addr (reversing the previous swap).

Possibly related PRs

  • Watfaq/clash-rs#1397: Adds shadowquic?/sunnyquic-iroh-quinn subfeature and git pinning; this PR removes those changes and updates the dependency version and source.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A version bump and swap so slight,
Dependencies fixed just right,
Address maps in proper place,
Shadowquic's bugs we now erase! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'fix: shadowquic udp proxy' accurately summarizes the main changes: fixing UDP proxy functionality in the shadowquic module, as evidenced by the corrected src/dst address handling and shadowquic dependency updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ibigbug ibigbug changed the title Fix sq fix: shadowquic udp proxy May 15, 2026
@ibigbug ibigbug merged commit 108a66c into Watfaq:master May 15, 2026
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants