Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New grunt icons #391

Merged
merged 3 commits into from
Jul 8, 2022
Merged

New grunt icons #391

merged 3 commits into from
Jul 8, 2022

Conversation

clburlison
Copy link
Contributor

Lazy fix to latest team rocket invasions. We should totally just fallback to 0i.png. This will allow users to see icons and hide/show latest invasions for the upcoming Johto event.

Copy link
Contributor

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-02-18 at 1 54 09 PM

Looks like you need add a default fallback value somewhere ( I can't remember where )

When I run npm run update/npm install the package-lock.json reverts to the old version, causing git issues. I'm stubborn and am still on npm v6, but I imagine most MapJS users at this point are still using an old npm version as well?

You can add an .npmrc file in the root of the project and set the contents to:

engine-strict=true

Then add this to the package.json:

  "engines": {
    "npm": ">=7.0.0"
  },

This way they'll get an error that at least instructs them what they need to do in order to run MapJS going forward (without causing git issues).

(base) ➜  mapFrontEnd git:(new-grunt-icons) ✗ npm install
npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for [email protected]: wanted: {"npm":">=7.0.0"} (current: {"node":"16.13.2","npm":"6.14.16"})
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"npm":">=7.0.0"}
npm ERR! notsup Actual:   {"npm":"6.14.16","node":"16.13.2"}

@versx
Copy link
Collaborator

versx commented Jun 16, 2022

🤔

@versx versx merged commit 0956eef into master Jul 8, 2022
@versx versx deleted the new-grunt-icons branch July 8, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants