Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 56 #70

Merged
merged 3 commits into from
Oct 13, 2018
Merged

Issue 56 #70

merged 3 commits into from
Oct 13, 2018

Conversation

WasiqB
Copy link
Owner

@WasiqB WasiqB commented Oct 13, 2018

Change list

Allows video recording for both Android and iOS.

New Config settings:

  • record: A new block under playback setting.
  • enabled: Identifies whether the feature is enabled or not.
  • bit_rate: an int value which takes in max as 20 MB/s. Only for Android
  • duration: an int indicates minutes. (3 mins max for Android and 10 mins max for iOS)
  • path: Folder location where the videos will be saved.
  • prefix: Prefix for file. Default is VID.
  • quality: Video Quality for the video. Allowed values are LOW, MEDIUM, HIGH, PHOTO. Default is MEDIUM. Only for iOS.
  • size: Size of the video based on Dimension. Only for Android.

New methods in all device classes

This will be functional only when recording is enabled in the config.

  • startRecording: Calling this will start recording.
  • stopRecording: Calling this will stop and save the recording to the configured path.

@WasiqB WasiqB added the type: feature New feature being introduced. label Oct 13, 2018
@WasiqB WasiqB added this to the Version 3.0.0 milestone Oct 13, 2018
@WasiqB WasiqB self-assigned this Oct 13, 2018
@WasiqB WasiqB requested a review from mfaisalkhatri October 13, 2018 17:41
Copy link
Collaborator

@mfaisalkhatri mfaisalkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mfaisalkhatri mfaisalkhatri merged commit d9a7f22 into develop Oct 13, 2018
@WasiqB WasiqB deleted the issue-56 branch October 14, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature being introduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants