Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "file_lines" issue in src/main/java/com/github/wasiqb/coteafs/appium/config/DeviceSetting.java #29

Closed
WasiqB opened this issue Jan 18, 2018 · 0 comments
Closed

Fix "file_lines" issue in src/main/java/com/github/wasiqb/coteafs/appium/config/DeviceSetting.java #29

WasiqB opened this issue Jan 18, 2018 · 0 comments
Assignees
@WasiqB
Labels
type: code-quality Issue highlighting code smells.
Milestone
Version 2.2.0

Comments

@WasiqB
Copy link
Owner

WasiqB commented Jan 18, 2018

File DeviceSetting.java has 412 lines of code (exceeds 250 allowed). Consider refactoring.

https://codeclimate.com/github/WasiqB/coteafs-appium/src/main/java/com/github/wasiqb/coteafs/appium/config/DeviceSetting.java#issue_5a4fa283e21b140001000069
@WasiqB WasiqB added the type: code-quality Issue highlighting code smells. label Jan 18, 2018
@WasiqB WasiqB self-assigned this Jan 18, 2018
@WasiqB WasiqB added this to the Version 2.2.0 milestone Jan 18, 2018
WasiqB added a commit that referenced this issue Jan 19, 2018
@WasiqB
Refactoring done for isuues #28, #29, #30, #31, #32, #33, #34 and #35 …
193e876 
…tickets.
WasiqB added a commit that referenced this issue Mar 9, 2018
@WasiqB
Fixed tickets #32, #35, #26, #36, #30, #28, #34, #33, #31, #29, #23, #24
1118107 
 and #37.
@WasiqB WasiqB closed this as completed Mar 9, 2018
WasiqB added a commit that referenced this issue Oct 2, 2018
@WasiqB
Refactoring done for isuues #28, #29, #30, #31, #32, #33, #34 and #35 …
a0e3eb9 
…tickets.
WasiqB added a commit that referenced this issue Oct 2, 2018
@WasiqB
Fixed tickets #32, #35, #26, #36, #30, #28, #34, #33, #31, #29, #23, #24
50a37d8 
 and #37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WasiqB WasiqB

Labels
type: code-quality Issue highlighting code smells.
Projects
None yet
Milestone
Version 2.2.0
Development

No branches or pull requests
1 participant
@WasiqB