File diff #947
Open
File diff #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WarmUpTill
force-pushed
the
file-diff
branch
from
4d4de2c
to
b50d6f9
Compare
Destroy666x
reviewed
Dec 13, 2023
| list->addItem(obs_module_text( | ||
| "AdvSceneSwitcher.condition.file.type.dateChange")); | ||
| static constexpr std::array< | ||
| std::tuple<MacroConditionFile::ConditionType, std::string_view>, |
There was a problem hiding this comment.
Just curious - wh this instead of map
There was a problem hiding this comment.
Ah just some unnecessary constexpr optimization ... no reason in particular.
WarmUpTill
force-pushed
the
file-diff
branch
from
b50d6f9
to
7ada858
Compare
|
Idea to improve it for bigger files - "Check only starting from last known line" checkbox or anything similar for kind of "tail" mode that would work in some scenarios. Otherwise much faster diffing algorithm would be needed, but that's impossible without moving the action IIRC and also wouldn't help that much with e.g. some game log files that can grow heavily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.