-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 iOS mobile linking guide #234
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/swift/guides/mobile-linking.md
Outdated
5. Wallet prompts user to return to Dapp manually | ||
6. User presses back/return button to return to Dapp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we mention here about WalletConnectRouter?
docs/swift/guides/mobile-linking.md
Outdated
|
||
1. Dapp redirects user automatically to previously chosen wallet | ||
2. Wallet prompts user to approve or reject request | ||
3. Wallet prompts user to return to Dapp manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be redirected with router as well
docs/swift/guides/mobile-linking.md
Outdated
|
||
```bash | ||
# For deep links | ||
examplewallet://wc?uri=wc:00e46b69-d0cc-4b3e-b6a2-cee442f97188@1?bridge=https%3A%2F%2Fbridge.walletconnect.org&key=91303dedf64285cbbaf9120f6e9d160a5c8aa3deb67017a3874cd272323f48ae |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is v1 uri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llbartekll Can you please change the format to v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has been done already, comment is outdated
|
||
5a. Wallet prompts user to return to Dapp manually | ||
|
||
5b. Wallet automatically returns to Dapp using `WalletConnectRouter` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not automatically. Special WalletConnectRouter call required to return to Dapp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I working on WalletConnectRouter docs. Need to add link to it here when I finished
|
||
When using WalletConnect on iOS and triggering a wallet interaction (e.g. when sending a transaction or signing a message), you may experience issues where the native app is not opened as expected and a browser navigation occurs instead. For some wallets (e.g. [Rainbow](https://rainbow.me)) this will present a fallback website, while other wallets (e.g. [MetaMask](https://metamask.io)) will redirect to the App Store. | ||
|
||
This issue occurs because app links on iOS will only open the native app when the following rules are followed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is known issue? Any links to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WalletConnect/walletconnect-monorepo#1165
ethers-io/ethers.js#3178
#210
https://wagmi.sh/examples/sign-in-with-ethereum#wrap-up
But there are many issues in monorepo too.
Co-authored-by: Artur Guseinov <[email protected]>
Co-authored-by: Artur Guseinov <[email protected]>
Ports the mobile linking doc from v1.
Creates a new Swift section called Guides
(Follows the format started by Kotlin >> https://docs.walletconnect.com/2.0/kotlin/guides/mobile-linking)