Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

feat: multi address #53

Merged
merged 16 commits into from
Dec 16, 2022
Merged

feat: multi address #53

merged 16 commits into from
Dec 16, 2022

Conversation

ganchoradkov
Copy link
Member

Description

Multi-address implementation as per specs WalletConnect/walletconnect-docs#355

How Has This Been Tested?

npm run test
canary

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@ganchoradkov ganchoradkov added the enhancement New feature or request label Dec 13, 2022
@ganchoradkov ganchoradkov self-assigned this Dec 13, 2022
@ganchoradkov ganchoradkov changed the title Feat/multi address feat: multi address Dec 13, 2022
devceline
devceline reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left some questions

devceline
devceline approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bkrem
bkrem approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@bkrem bkrem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

So follow-up items here are:

  • prep v2.0.0 release
  • update the docs to reflect this
  • update Cloud submissions form to not specify Auth v1 (I can take care of this anyways)

Anything I missed?

@ganchoradkov
Copy link
Member Author

LGTM muscle

So follow-up items here are:

  • prep v2.0.0 release
  • update the docs to reflect this
  • update Cloud submissions form to not specify Auth v1 (I can take care of this anyways)

Anything I missed?

Updating the demo apps too

@ganchoradkov ganchoradkov merged commit ea5ae0d into main Dec 16, 2022
@ganchoradkov ganchoradkov deleted the feat/multi-address branch December 16, 2022 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkrem bkrem bkrem approved these changes

@devceline devceline devceline approved these changes

Assignees

@ganchoradkov ganchoradkov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganchoradkov @bkrem @devceline