[Web3Wallet] Echo #751
Merged
[Web3Wallet] Echo #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
approved these changes
Mar 17, 2023
# Conflicts: # Sources/Web3Wallet/Web3WalletClient.swift
llbartekll
approved these changes
Mar 23, 2023
Sources/Web3Wallet/Web3Wallet.swift
Outdated
| @@ -35,10 +36,11 @@ public class Web3Wallet { | |||
| /// - Parameters: | |||
| /// - metadata: App metadata | |||
| /// - signerFactory: Auth signers factory | |||
| static public func configure(metadata: AppMetadata, signerFactory: SignerFactory) { | |||
| static public func configure(metadata: AppMetadata, signerFactory: SignerFactory, echoHost: String = "echo.walletconnect.com", environment: APNSEnvironment) { | |||
There was a problem hiding this comment.
should the echo host be an optional? not every project is using our PN solution.
There was a problem hiding this comment.
you mean if we pass nil then Echo won't call configure? what about environment then?
There was a problem hiding this comment.
add echo config? that is optional and contains both?
There was a problem hiding this comment.
or it's good, just add a default environment?
llbartekll
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Dilligence