[WalletApp] Small fixes #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional namespaces
llbartekll
approved these changes
Mar 9, 2023
Comment on lines
+6
to
+15
| do { | ||
| let result = try Signer.sign(request: sessionRequest) | ||
| try await Web3Wallet.instance.respond( | ||
| topic: sessionRequest.topic, | ||
| requestId: sessionRequest.id, | ||
| response: .response(result) | ||
| ) | ||
| } catch { | ||
| throw error | ||
| } |
There was a problem hiding this comment.
what do we need do catch block here?
There was a problem hiding this comment.
Just to pass an error to the top level for presenting it with alert on UI
There was a problem hiding this comment.
but wouldn't it work the same way if it just throws in line 7 or 8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw error when method is not implemented, update UI for requested/optional namespaces
Due Dilligence