Echo register auth #740
Echo register auth #740
Conversation
llbartekll
force-pushed
the
echo-register-auth
branch
from
7676520 to
b8c32fa
Compare
|
|
||
| actor EchoRegisterService { | ||
| private let httpClient: HTTPClient | ||
| private let projectId: String | ||
| private let clientId: String | ||
| private let logger: ConsoleLogging | ||
| private let environment: APNSEnvironment | ||
| private let echoAuthenticator: EchoAuthenticating | ||
| // DID method specific identifier | ||
| private var clientIdMutlibase: String { | ||
| return clientId.replacingOccurrences(of: "did:key:", with: "") |
There was a problem hiding this comment.
may be use DIDKey object?
There was a problem hiding this comment.
in what way?
actually clientIdStorage could return DIDKey?
There was a problem hiding this comment.
i mean:
let clientId: DIDKey
and after you can get the string with did(prefix: Bool, variant: DIDKeyVariant)
I created DIDKey type to avoid of using string keys. Actually good idea to return DIDKey from clientIdStorage
There was a problem hiding this comment.
clientID cannot be DIDkey because we could confuse the variant
| @@ -12,6 +12,7 @@ public protocol HTTPService { | |||
| var method: HTTPMethod { get } | |||
| var body: Data? { get } | |||
| var queryParameters: [String: String]? { get } | |||
| var headerFields: [String: String]? { get } | |||
There was a problem hiding this comment.
may be additionalHeaders, because it's not represent all request headers as we are setting Content-Type separately after
| @@ -122,7 +122,7 @@ private extension InvitationHandlingService { | |||
| let inviterAccount = try await identityClient.resolveIdentity(iss: claims.iss) | |||
| // TODO: Should we cache it? | |||
| let inviteePublicKey = try await identityClient.resolveInvite(account: inviterAccount) | |||
| let inviterPublicKey = invite.inviterPublicKey.did(prefix: false, variant: .X25519) | |||
| let inviterPublicKey = invite.inviterPublicKey.multibase(variant: .ED25519) | |||
There was a problem hiding this comment.
why you changed for ED25519? inviterPublic key is creating by createX25519KeyPair
There was a problem hiding this comment.
also could you change it please to .did with prefix
There was a problem hiding this comment.
was a typo, added did prefix too
Description
AuthorizationheaderResolves # (issue)
How Has This Been Tested?
Due Dilligence