Batch subscribe #716
Merged
Batch subscribe #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
approved these changes
Feb 15, 2023
flypaper0
reviewed
Feb 16, 2023
| @@ -32,6 +32,7 @@ class ResubscriptionService { | |||
|
|
|||
| func resubscribe(account: Account) async throws { | |||
| let topics = chatStorage.getThreads(account: account).map { $0.topic } | |||
| guard !topics.isEmpty else { return } | |||
There was a problem hiding this comment.
may be do this check inside butchSubscribe?
There was a problem hiding this comment.
we do but it throws an error batchContainsNoItems
flypaper0
reviewed
Feb 16, 2023
| .asRPCRequest() | ||
| let message = try! request.asJSONEncodedString() | ||
| var cancellable: AnyCancellable? | ||
| cancellable = batchSubscriptionResponsePublisher |
There was a problem hiding this comment.
we are doing the same logic in different places. Could we refactor it somehow?
flypaper0
reviewed
Feb 16, 2023
| @@ -292,6 +317,8 @@ public final class RelayClient { | |||
| requestAcknowledgePublisherSubject.send(response.id) | |||
| } else if let subscriptionId = try? anyCodable.get(String.self) { | |||
| subscriptionResponsePublisherSubject.send((response.id, subscriptionId)) | |||
| } else if let subscriptionIds = try? anyCodable.get([String].self) { | |||
| batchSubscriptionResponsePublisherSubject.send((response.id, subscriptionIds)) | |||
There was a problem hiding this comment.
do we need to use different ack publishers? Can we use one?
flypaper0
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #708
How Has This Been Tested?
Due Dilligence