[Push] Add push messages history getter, add account to subscription #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add account to push subscription
alexander-lsvk
approved these changes
Jan 23, 2023
…lletConnect/WalletConnectSwiftV2 into add-get-push-messages # Conflicts: # Sources/WalletConnectPush/Types/PushSubscription.swift # Sources/WalletConnectUtils/RPCHistory/RPCHistory.swift
flypaper0
reviewed
Jan 25, 2023
| @@ -45,6 +46,7 @@ public class WalletPushClient { | |||
| proposeResponder: PushRequestResponder, | |||
| pushMessageSubscriber: PushMessageSubscriber, | |||
| subscriptionsProvider: SubscriptionsProvider, | |||
| pushMessagesProvider: PushMessagesProvider, | |||
| deletePushSubscriptionService: DeletePushSubscriptionService, | |||
| deletePushSubscriptionSubscriber: DeletePushSubscriptionSubscriber, | |||
| resubscribeService: PushResubscribeService) { | |||
There was a problem hiding this comment.
resubscribeService unused in PushClient
There was a problem hiding this comment.
it is in use, it's calling setUpResubscription func after initialisation
flypaper0
reviewed
Jan 25, 2023
| import Foundation | ||
| import WalletConnectUtils | ||
|
|
||
| class PushMessagesProvider { |
flypaper0
reviewed
Jan 25, 2023
| public func getAll<Object: Codable>(of type: Object.Type, topic: String) -> [Object] { | ||
| return storage.getAll() | ||
| .filter{$0.topic == topic} | ||
| .compactMap { record in |
There was a problem hiding this comment.
.compactMap { try? $0.request.params?.get(Object.self) }
flypaper0
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to spec change
https://github.com/WalletConnect/walletconnect-docs/pull/416/files