Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web3Inbox] SDK Structure with simple messaging #666

Merged
merged 15 commits into from
Jan 23, 2023

Conversation

flypaper0
Copy link
Contributor

@flypaper0 flypaper0 commented Jan 16, 2023

Description

  • Web3InboxSDK structure
  • setting account, threads, messages, invites
  • accepting invites
  • sending messages
  • messages, invites storages now working on top of RPC History
  • NetworkingInteractor batchSubscribe

Resolves #644

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

case threads = "com.walletconnect.chat.threads"
case messages = "com.walletconnect.chat.messages"
case jsonRpcHistory = "com.walletconnect.chat.jsonRpcHistory"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this case too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@flypaper0 flypaper0 merged commit 50e5704 into develop Jan 23, 2023
@flypaper0 flypaper0 deleted the feature/web3inbox-structure-#644 branch January 23, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants