Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WalletApp] Session requests handling #664

Merged
merged 2 commits into from
Jan 18, 2023
Merged

[WalletApp] Session requests handling #664

merged 2 commits into from
Jan 18, 2023

Conversation

alexander-lsvk
Copy link
Contributor

Description

Sessions Requests
Simulator Screen Shot - iPhone 14 Pro - 2023-01-12 at 16 45 36 Simulator Screen Shot - iPhone 14 Pro - 2023-01-12 at 16 45 12
Screenshot 2023-01-12 at 16 45 41 Simulator Screen Shot - iPhone 14 Pro - 2023-01-12 at 16 45 26

Due Dilligence

  • Breaking change
  • Requires a documentation update

llbartekll
llbartekll approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and works and looks good 👍 Do you think we could add session disconnection by swiping the session cell? like we had in first example app.

@llbartekll llbartekll requested a review from flypaper0 January 13, 2023 12:17
@alexander-lsvk
Copy link
Contributor Author

IMG_5049

@llbartekll swipe to delete

@alexander-lsvk alexander-lsvk merged commit f7157a4 into develop Jan 18, 2023
@alexander-lsvk alexander-lsvk deleted the sign-requests branch January 18, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flypaper0 flypaper0 flypaper0 approved these changes

@llbartekll llbartekll llbartekll approved these changes

Assignees

@flypaper0 flypaper0

@llbartekll llbartekll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-lsvk @flypaper0 @llbartekll