[Push] configure echo over push config #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
changed the title
flypaper0
reviewed
Jan 13, 2023
Sources/WalletConnectPush/Push.swift
Outdated
| static public func configure() throws { | ||
| var clientId: String! | ||
| do { | ||
| clientId = try Networking.interactor.getClientId() |
There was a problem hiding this comment.
should clientId always exist? We can create generate it if not possible to try keychain.read(key: key)
There was a problem hiding this comment.
It is created automatically if it does not exist yet but there is possible error from writing/reading keychain, thats why we use try.
Make sense?
flypaper0
approved these changes
Jan 13, 2023
llbartekll
force-pushed
the
push-config
branch
from
1845d4a to
e4f964b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add push config in order to not require from sdk consumer configuration of Echo
How Has This Been Tested?
manual testing with Example App
Due Dilligence