Feature/chat wallet app extraction #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexander-lsvk
commented
Jan 3, 2023
•
alexander-lsvk
commented
- Remove wallet from Chat app
- Implement new Wallet app with updated design using Web3Wallet lib
- Breaking change
- Requires a documentation update
…t-app-extraction # Conflicts: # Example/ChatWallet/PresentationLayer/Wallet/AuthRequest/AuthRequestInteractor.swift # Example/ExampleApp.xcodeproj/project.pbxproj
llbartekll
reviewed
Jan 5, 2023
Example/Showcase/Classes/PresentationLayer/Chat/Welcome/WelcomeInteractor.swift
Outdated
Show resolved
Hide resolved
llbartekll
reviewed
Jan 5, 2023
| window = UIWindow(windowScene: windowScene) | ||
| window?.makeKeyAndVisible() | ||
|
|
||
| app.uri = connectionOptions.urlContexts.first?.url.absoluteString.replacingOccurrences(of: "walletapp://wc?uri=", with: "") |
There was a problem hiding this comment.
we need to switch to universal linking later
llbartekll
reviewed
Jan 5, 2023
Example/WalletApp/DomainLayer/AccountStorage/AccountStorage.swift
Outdated
Show resolved
Hide resolved
llbartekll
reviewed
Jan 5, 2023
llbartekll
reviewed
Jan 5, 2023
llbartekll
reviewed
Jan 5, 2023
llbartekll
reviewed
Jan 5, 2023
llbartekll
reviewed
Jan 5, 2023
| /// Publisher that sends sessions on every sessions update | ||
| /// | ||
| /// Event will be emited on controller and non-controller clients. | ||
| public var sessionsPublisher: AnyPublisher<[Session], Never> { |
llbartekll
reviewed
Jan 5, 2023
|
@llbartekll updated with session request and PR fixes |
flypaper0
reviewed
Jan 6, 2023
|
Is it possible to fix modal background appearance on "Enter a WalletConnect URI" screen? May be show modal, and after animate background opacity. Not critical |
|
Why WalletApp redirect to Showcase after Approving Auth Request? |
flypaper0
reviewed
Jan 6, 2023
Example/Showcase/Classes/DomainLayer/SocketFactory/SocketFactory.swift
Outdated
Show resolved
Hide resolved
flypaper0
reviewed
Jan 6, 2023
Example/Showcase/Classes/PresentationLayer/Chat/Welcome/WelcomeInteractor.swift
Outdated
Show resolved
Hide resolved
flypaper0
reviewed
Jan 6, 2023
flypaper0
reviewed
Jan 6, 2023
flypaper0
reviewed
Jan 6, 2023
flypaper0
reviewed
Jan 6, 2023
Example/WalletApp/DomainLayer/SocketFactory/SocketFactory.swift
Outdated
Show resolved
Hide resolved
@flypaper0 in Showcase you receive Cacao object after, this redirection is kind of success imitation, but I can remove it or change if needed |
flypaper0
reviewed
Jan 6, 2023
Example/WalletApp/PresentationLayer/Wallet/ConnectionDetails/ConnectionDetailsView.swift
Outdated
Show resolved
Hide resolved
flypaper0
reviewed
Jan 6, 2023
Example/WalletApp/PresentationLayer/Wallet/PasteUri/PasteUriView.swift
Outdated
Show resolved
Hide resolved
flypaper0
reviewed
Jan 6, 2023
flypaper0
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.