-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web3Wallet implementation + integration tests #638
Conversation
signerFactory: config.signerFactory, | ||
networkingClient: Networking.interactor, | ||
pairingRegisterer: Pair.registerer, | ||
pairingClient: Pair.instance as! PairingClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llbartekll as I remember we found the way how to avoid force casts for pairing client. Or we decided to leave it like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have fixed it for Networking having two vars: instance
and interactor
I think we could do the same with pairing
@@ -0,0 +1,3 @@ | |||
#if !CocoaPods | |||
@_exported import WalletConnectPairing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to remove all packages imports from all files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cocoapods putting all sources in single framework, so it doesn't know what is Auth, WalletConnectSign etc
Need to remove all
import WalletConnectSign
import Auth
And imports should be
@_exported import Auth
@_exported import WalletConnectSign
Agree it looks like a little wired but supporting both SPM and Cocoapods is a kind of pain
@llbartekll @flypaper0 I added unit tests for I'm not really satisfied with this Any suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
For me all namings is good, but it must be consistant across project and all our sdk's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
# Conflicts: # Example/ExampleApp.xcodeproj/project.pbxproj
Description
Web3Wallet proxy implementation according to the interface described here