[Push, Echo] api milestone 1 #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
llbartekll
commented
Dec 5, 2022
•
llbartekll
commented
- Add Echo target - component for registering a client at Echo server
- has not been e2e tested yet, there is still issue with echo server
- Push API
- Add Push subscription negotiation
- Add Wallet and Dapp clients - with not all methods implemented
- allows to send push message over relay network
- integration tests testDappSendsPushMessage and testWalletApprovesPushRequest pass
- There is push registration pulled from Derek's PR, it will be replaced with Echo SDK registration when issue on Echo server is fixed.
…letConnectSwiftV2 into push-api-milestone-1
add client factories
- add singletones for dapp and wallet push clients
arein
reviewed
Dec 6, 2022
…V2 into push-api-milestone-1 # Conflicts: # Example/ExampleApp.xcodeproj/project.pbxproj # Example/IntegrationTests/Pairing/PairingTests.swift
flypaper0
reviewed
Dec 7, 2022
flypaper0
reviewed
Dec 7, 2022
| wait(for: [expectation], timeout: InputConfig.defaultTimeout) | ||
| } | ||
|
|
||
| func testWalletRejectsPushRequest() { |
There was a problem hiding this comment.
Planning to implement in this PR?
There was a problem hiding this comment.
but it is not implemented in the engine yet
flypaper0
reviewed
Dec 7, 2022
flypaper0
reviewed
Dec 7, 2022
| } | ||
|
|
||
| private func generateAgreementKeys(peerPublicKeyHex: String, selfpublicKeyHex: String) throws -> (topic: String, keys: AgreementKeys) { | ||
| let selfPublicKey = try AgreementPublicKey(hex: selfpublicKeyHex) |
There was a problem hiding this comment.
just an idea. We doing same actions to generate keys, topic, setAgreementSecret in many places. May be we should move it in KMS package?
There was a problem hiding this comment.
maybe worth to consider, should we open an issue?
flypaper0
reviewed
Dec 7, 2022
|
|
||
| import Foundation | ||
|
|
||
| public struct PushMessage: Codable { |
There was a problem hiding this comment.
so far, yes but it may be a good suggestion to change specs
flypaper0
reviewed
Dec 7, 2022
flypaper0
approved these changes
Dec 7, 2022
alexander-lsvk
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.