[Networking] #502 Add tll and prompt to requests #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
reviewed
Sep 27, 2022
| } | ||
| } | ||
| struct AuthRequestProtocolMethod: ProtocolMethod { | ||
| var method: String = "wc_authRequest" |
There was a problem hiding this comment.
because xcode has generated it that as vars. Anyway good point, I am changing for lets
flypaper0
reviewed
Sep 27, 2022
flypaper0
reviewed
Sep 27, 2022
flypaper0
reviewed
Sep 27, 2022
| @@ -59,28 +59,29 @@ final class SessionEngine { | |||
| let chainRequest = SessionType.RequestParams.Request(method: request.method, params: request.params) | |||
| let sessionRequestParams = SessionType.RequestParams(request: chainRequest, chainId: request.chainId) | |||
|
|
|||
| let rpcRequest = RPCRequest(method: SignProtocolMethod.sessionRequest.method, params: sessionRequestParams) | |||
| try await networkingInteractor.request(rpcRequest, topic: request.topic, tag: SignProtocolMethod.sessionRequest.requestTag) | |||
| let rpcRequest = RPCRequest(method: SessionRequestProtocolMethod().method, params: sessionRequestParams) | |||
There was a problem hiding this comment.
SessionRequestProtocolMethod() to variable? To avoid typo later
There was a problem hiding this comment.
but may be it better to isolate RPCRequest creation inside Networking package. But it another task of course
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #502
How Has This Been Tested?
with integrations tests
Due Dilligence