[Relay] Retry on connection error #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
requested changes
Sep 15, 2022
| } | ||
| } | ||
|
|
||
| private func protectedSend(_ string: String, timeout: Int = 5, completion: @escaping (Error?) -> Void) { |
There was a problem hiding this comment.
I would move it to dispatcher.
Relay client is responsible for client<->relay interactions - subscribe/publish etc.
dispatcher is responsible for managing behaviour/policy of sending requests - unaware of the protocol methods etc.
and protectedSend to me sounds more like dispatcher responsibility.
flypaper0
force-pushed
the
feature/relay-retry
branch
from
5dde7ad to
e8a2762
Compare
llbartekll
approved these changes
Sep 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence