[CI] Host URL arg #492
Merged
[CI] Host URL arg #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arein
approved these changes
Sep 7, 2022
Comment on lines
+30
to
+32
| -destination 'platform=iOS Simulator,name=iPhone 13' \ | ||
| RELAY_HOST='relay.walletconnect.com' \ | ||
| test" |
There was a problem hiding this comment.
nit (we can do this in a follow up PR) but it would be nice to make another input at the top of the file with a default value of relay.walletconnect.com to allow callers to override
There was a problem hiding this comment.
relay.walletconnect.com is the default value (if not passing RELAY_HOST param). Is it enough?
llbartekll
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RELAY_URL env variable could be passed via GH actions script
Resolves # (issue)
Due Dilligence