Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Generic NetworkInteractor #483

Merged
merged 5 commits into from
Sep 5, 2022
Merged

[Refactor] Generic NetworkInteractor #483

merged 5 commits into from
Sep 5, 2022

Conversation

flypaper0
Copy link
Contributor

@flypaper0 flypaper0 commented Sep 2, 2022 •
edited
Loading

Description

  • Generic NetworkInteractor publishers
  • NetworkRequest Enums

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@flypaper0 flypaper0 requested a review from llbartekll September 2, 2022 20:39
@arein arein added the accepted label Sep 2, 2022
@flypaper0 flypaper0 marked this pull request as ready for review September 5, 2022 08:45
llbartekll
llbartekll approved these changes Sep 5, 2022
View reviewed changes
Sources/Auth/Services/App/AppRequestService.swift Outdated Show resolved Hide resolved
Sources/Auth/Services/App/AppRespondSubscriber.swift Outdated Show resolved Hide resolved
@flypaper0 flypaper0 merged commit 7cb497c into develop Sep 5, 2022
@flypaper0 flypaper0 deleted the feature/genaric-networkinteractor branch September 5, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

Assignees
No one assigned
Labels
accepted
Projects
Swift SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flypaper0 @llbartekll @arein