[Refactor] Networking package Part 1 #391 #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
approved these changes
Sep 2, 2022
Comment on lines
-16
to
+18
| let jsonRpcHistory = JsonRpcHistory<ChatRequestParams>(logger: logger, keyValueStore: CodableStore<JsonRpcRecord>(defaults: keyValueStorage, identifier: StorageDomainIdentifiers.jsonRpcHistory.rawValue)) | ||
| let networkingInteractor = NetworkingInteractor(relayClient: relayClient, serializer: serialiser, logger: logger, jsonRpcHistory: jsonRpcHistory) | ||
| let rpcHistory = RPCHistory(keyValueStore: CodableStore<RPCHistory.Record>(defaults: keyValueStorage, identifier: StorageDomainIdentifiers.jsonRpcHistory.rawValue)) |
There was a problem hiding this comment.
have you tried if old records will be derived with new RPCHistory
There was a problem hiding this comment.
decided to not make migration
| }.store(in: &publishers) | ||
| } | ||
| networkingInteractor.requestPublisher.sink { [unowned self] payload in | ||
| guard payload.request.method == "wc_chatInvite" |
There was a problem hiding this comment.
what do you think if at some point we have an enum with protocol methods? so we do like:
guard payload.request.method == ChatProtocolMethods.invite.rawValue
There was a problem hiding this comment.
I will solve these issue in next PR
flypaper0
force-pushed
the
feature/networking-package-#391
branch
from
429b32e to
a9f921b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #391
How Has This Been Tested?
Run unit/integration tests
Due Dilligence