Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] #472 extend pairing #477

Merged
merged 4 commits into from
Sep 1, 2022
Merged

[Auth] #472 extend pairing #477

merged 4 commits into from
Sep 1, 2022

Conversation

llbartekll
Copy link
Contributor

@llbartekll llbartekll commented Aug 31, 2022

Description

Extend pairing on app from 5minutes to 30days after response from wallet is received. Extension happens on every response.

Resolves #472

How Has This Been Tested?

manually

Due Dilligence

  • Breaking change
  • Requires a documentation update

@llbartekll llbartekll changed the base branch from main to develop August 31, 2022 07:55
@arein arein added the accepted label Aug 31, 2022
@llbartekll llbartekll marked this pull request as draft August 31, 2022 07:55
@llbartekll llbartekll changed the title #472 extend pairing [Auth] #472 extend pairing Aug 31, 2022
@llbartekll llbartekll requested a review from flypaper0 August 31, 2022 08:26
@llbartekll llbartekll marked this pull request as ready for review August 31, 2022 09:17
@@ -62,4 +67,15 @@ class AppRespondSubscriber {

}.store(in: &publishers)
}

private func activatePairingIfNeeded(id: RPCID) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throws?

@llbartekll llbartekll merged commit bc9095a into develop Sep 1, 2022
@llbartekll llbartekll deleted the #472-extend-pairing branch September 1, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants