Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Test respond error #461

Merged
merged 5 commits into from
Aug 24, 2022
Merged

[Auth] Test respond error #461

merged 5 commits into from
Aug 24, 2022

Conversation

llbartekll
Copy link
Contributor

Description

  • handle peer error response
  • add testUserRespondError
  • add reject method to public interface

Resolves #459 #460

How Has This Been Tested?

  • integration tests

Due Dilligence

  • Breaking change
  • Requires a documentation update

@llbartekll llbartekll requested a review from flypaper0 August 23, 2022 12:37
@arein arein added the accepted label Aug 23, 2022
@llbartekll llbartekll changed the base branch from main to develop August 23, 2022 12:38
try await walletRespondService.respond(requestId: requestId, signature: signature, account: account)
}

public func reject(requestId: RPCID) async throws {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@llbartekll llbartekll changed the title Test respond error [Auth] Test respond error Aug 24, 2022
@llbartekll llbartekll merged commit c97545a into develop Aug 24, 2022
@llbartekll llbartekll deleted the test-respond-error branch August 24, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Auth] handle error response
3 participants