Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#454 Update WalletConnectURI with API identifier prefix #455

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

sekimondre
Copy link

Description

Updates WalletConnectURI to include a API prefix in its format. Implementation is backwards compatible with legacy format.

Resolves #454

How Has This Been Tested?

Unit tests

@sekimondre sekimondre self-assigned this Aug 22, 2022
@arein arein added the accepted label Aug 22, 2022
Copy link
Contributor

@flypaper0 flypaper0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we need tests for it?

@llbartekll llbartekll merged commit 6aad276 into develop Aug 24, 2022
@llbartekll llbartekll deleted the #454-uri-api-prefix branch August 24, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants