[Auth] Handle errors #449
Merged
[Auth] Handle errors #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
force-pushed
the
feature/auth-handle-errors-#445
branch
from
2d59141 to
0396e44
Compare
llbartekll
reviewed
Aug 19, 2022
Sources/Auth/AuthClient.swift
Outdated
| @@ -87,9 +87,9 @@ public class AuthClient { | |||
| try await appRequestService.request(params: params, topic: topic) | |||
| } | |||
|
|
|||
| public func respond(_ result: Result<RespondParams, ErrorCode>) async throws { | |||
| public func respond(requestId: RPCID, result: Result<CacaoSignature, ExternalError>) async throws { | |||
There was a problem hiding this comment.
I think here it should be a protocol error as well, as it is send to a peer
| }.store(in: &publishers) | ||
| } | ||
|
|
||
| private func respondError(_ error: InternalError, topic: String, requestId: RPCID) { |
There was a problem hiding this comment.
would it make sense if this method is async?
There was a problem hiding this comment.
there is no async context. I think it will be the same
| @@ -0,0 +1,22 @@ | |||
| import Foundation | |||
|
|
|||
| public enum ExternalError: Codable, Equatable, Error { | |||
There was a problem hiding this comment.
My suggestion: ExternalError - errors which comes from outside. InternalError - errors which could occur during SDK execution
Sources/Auth/AuthClient.swift
Outdated
| private var authResponsePublisherSubject = PassthroughSubject<(id: RPCID, result: Result<Cacao, ErrorCode>), Never>() | ||
| public var authResponsePublisher: AnyPublisher<(id: RPCID, result: Result<Cacao, ErrorCode>), Never> { | ||
| private var authResponsePublisherSubject = PassthroughSubject<(id: RPCID, result: Result<Cacao, InternalError>), Never>() | ||
| public var authResponsePublisher: AnyPublisher<(id: RPCID, result: Result<Cacao, InternalError>), Never> { |
There was a problem hiding this comment.
I think the error can be a protocol error.
consider case when wallet rejects a request - user initiated
There was a problem hiding this comment.
so if it can be InternalError and ExternalError maybe we could have only one public error like: AuthError?
llbartekll
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #445
How Has This Been Tested?
Run integration and Auth unit tests
Due Dilligence