Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] #416 auth request test #448

Merged
merged 19 commits into from
Aug 19, 2022
Merged

[Auth] #416 auth request test #448

merged 19 commits into from
Aug 19, 2022

Conversation

llbartekll
Copy link
Contributor

@llbartekll llbartekll commented Aug 18, 2022 •
edited
Loading

Description

  • adds unsubscribe method for networking interactor
  • implements cacao formatter
  • add e2e auth tests: testRequest and testRespondSuccess

Resolves # #400 #416

How Has This Been Tested?

  • automatically - runs with integration tests target

Due Dilligence

  • Breaking change
  • Requires a documentation update

@llbartekll
create request test
895da5c
@llbartekll
fix subscription bug
81152cc
@llbartekll
fix buiild
a29ad06
@llbartekll
refactor Auth client factory
824a0ee
@llbartekll
update auth test
a4cb644
@llbartekll
Merge branch 'develop_main' of github.com:WalletConnect/WalletConnect…
4fa5f18 
…SwiftV2 into #416-auth-request-test
@llbartekll
fix build
57b5400
@llbartekll
pass test request
b289acc
@llbartekll
savepoint respond test
3497e47
@llbartekll
comment out code
c4f0ffe
@llbartekll
Merge branch 'develop' of github.com:WalletConnect/WalletConnectSwift…
04da63a 
…V2 into #416-auth-request-test

# Conflicts:
#	Example/ExampleApp.xcodeproj/project.pbxproj
#	Sources/Auth/AuthClientFactory.swift
@llbartekll
savepoint
3560182
@llbartekll
#400 cacao object formatter
51b5e54
@llbartekll
savepoint
6d463df
@llbartekll
Update tests
55864eb 
fix key exchange bug
@llbartekll
fix protocol issue
a2dc202
@llbartekll
fix protocol issue - store pub key for response topic
6d3f46c
@llbartekll
update auth e2e test: received successful response
a3239f8
@llbartekll llbartekll marked this pull request as draft August 18, 2022 13:33
@llbartekll llbartekll changed the base branch from main to develop August 18, 2022 13:33
@arein arein added the accepted label Aug 18, 2022
@llbartekll
update style, logs
70d85d4 
add unsubscribe to networking interactor
@llbartekll llbartekll marked this pull request as ready for review August 19, 2022 08:49
@llbartekll llbartekll merged commit adf3328 into develop Aug 19, 2022
@llbartekll llbartekll deleted the #416-auth-request-test branch August 19, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flypaper0 flypaper0 flypaper0 approved these changes

@sekimondre sekimondre Awaiting requested review from sekimondre

Assignees
No one assigned
Labels
accepted
Projects
Swift SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llbartekll @flypaper0 @arein