[Relay] Relay Singleton instance #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
reviewed
Aug 16, 2022
There was a problem hiding this comment.
Good work! much cleaner.
I just wonder if we should not require relay configuration separately, consider that wallet want to integrate sign and chat alongside wouldn't it be better if configuration looks as follows?:
- relay.configure(projectId etc.)
- chat.configure()
- sign.configure()
imo currently is better for only one sdk because we do not expose relay configuration but it will e quite weird if we require:
1 . chat.configure(projectId? etc)
2 . sign.configure(projectId? etc)
sekimondre
approved these changes
Aug 16, 2022
llbartekll
approved these changes
Aug 17, 2022
| func didChangeSocketConnectionStatus(_ status: SocketConnectionStatus) { | ||
| onConnected?() | ||
| } | ||
| class ClientDelegate { |
There was a problem hiding this comment.
actually, we do not depend on sign delegate anymore , so we could remove this class entirely.
maybe we can create an issue and do it at some point?
There was a problem hiding this comment.
ClientDelegate usage looks good in tests for me
There was a problem hiding this comment.
we could subscribe for SignClients events only now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #430 #431 #432
How Has This Been Tested?
Due Dilligence
Relay Client configuration walletconnect-docs#236