Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] EIP-155 signature fix #436

Merged
merged 1 commit into from
Aug 16, 2022
Merged

[Hotfix] EIP-155 signature fix #436

merged 1 commit into from
Aug 16, 2022

Conversation

flypaper0
Copy link
Contributor

What changed
Replay protection implemented

@arein arein added the accepted label Aug 12, 2022
llbartekll
llbartekll approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought nonce is the only reply attack protection.
missed it specs

@flypaper0 flypaper0 merged commit 953df6a into develop Aug 16, 2022
@flypaper0 flypaper0 deleted the hotfix/eip155-signature branch August 16, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sekimondre sekimondre sekimondre approved these changes

@llbartekll llbartekll llbartekll approved these changes

Assignees
No one assigned
Labels
accepted
Projects
Swift SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flypaper0 @sekimondre @llbartekll @arein