#382 auth networking interactor #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
approved these changes
Aug 9, 2022
sekimondre
approved these changes
Aug 9, 2022
| @@ -11,6 +11,7 @@ protocol NetworkInteracting { | |||
| func subscribe(topic: String) async throws | |||
| func unsubscribe(topic: String) | |||
| func request(_ request: RPCRequest, topic: String, tag: Int, envelopeType: Envelope.EnvelopeType) async throws | |||
| func requestNetworkAck(_ request: RPCRequest, topic: String, tag: Int) async throws | |||
There was a problem hiding this comment.
We need to get rid of this kind of function that waits for the network acknowledgement (at least if we want to generalize the interactor). We need to find a better way around to wait for the acknowledgement on calls that need it.
There was a problem hiding this comment.
I am not sure I understand, what you mean by generalize? isn't this approach generic and interface could be shared by all SDKs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
requestNetworkAckfunction that completes with an acknowledgement from the relay network.handles incoming requests and responses to networking interactor and publishes decrypted rpc requests to subscribers