Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sign] #372 Clean protocol codes #419

Merged
merged 4 commits into from
Aug 10, 2022
Merged

[Sign] #372 Clean protocol codes #419

merged 4 commits into from
Aug 10, 2022

Conversation

llbartekll
Copy link
Contributor

@llbartekll llbartekll commented Aug 8, 2022

update protocol codes to match specs
close #372

@llbartekll llbartekll marked this pull request as draft August 8, 2022 12:50
@llbartekll llbartekll changed the title Clean protocol codes [Sign] #372 Clean protocol codes Aug 8, 2022
@arein arein added the accepted label Aug 8, 2022
@llbartekll llbartekll marked this pull request as ready for review August 9, 2022 08:44
@llbartekll llbartekll self-assigned this Aug 9, 2022
Copy link
Contributor

@flypaper0 flypaper0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes according specs?

@llbartekll
Copy link
Contributor Author

Correct

@llbartekll llbartekll merged commit b64bbe4 into develop Aug 10, 2022
@llbartekll llbartekll deleted the #372-codes branch August 10, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants