Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.9.3-rc.0 #412

Merged
merged 25 commits into from
Aug 8, 2022
Merged

v0.9.3-rc.0 #412

merged 25 commits into from
Aug 8, 2022

Conversation

llbartekll
Copy link
Contributor

No description provided.

llbartekll and others added 22 commits August 3, 2022 14:12
@llbartekll
Add Auth Respond Subscriber
68ffab8
@llbartekll
Update AuthRespondSubscriber
70042a5
@llbartekll
run lint
0051b90
@llbartekll
Merge branch 'develop' of github.com:WalletConnect/WalletConnectSwift…
06875f3 
…V2 into #396-Auth-Respond-Subscriber

# Conflicts:
#	Sources/Auth/Services/Wallet/AuthRequestSubscriber.swift
#	Tests/AuthTests/Stubs/RequestSubscriptionPayload.swift
@llbartekll
Merge pull request #404 from WalletConnect/#396-Auth-Respond-Subscriber
37ef8d1 
#396 auth respond subscriber
@llbartekll
Add siwe message
cf8cdc9
@llbartekll
update siwe message
b8da4f1
@llbartekll
Add siwe formatter test
3ca3f6a
@llbartekll
fix siwe formatter tests
835a984
@llbartekll
change scope of siwe message
6acc703
@llbartekll
update siwemessage
d6173f3
@llbartekll
update resources
ce32f44
@flypaper0
testNilOptionalParamsMessage
bac3ff4
@llbartekll
Add test cases
e44379d
@llbartekll
test
df7df54
@llbartekll
add destination
9b3dd7d
@llbartekll
fix jsonrpc test id params
7dbbf7d
@llbartekll
fix rpc tests
e16941f
@llbartekll
comment out periodically failing test
6d4246d
@llbartekll
comment out failing assertion
a7d4d88
@flypaper0
Priority high
410e0ab
@flypaper0
Merge pull request #410 from WalletConnect/unit-tests
6bcd0ba 
Fix unit test run
@llbartekll llbartekll requested a review from flypaper0 August 8, 2022 09:42
@arein arein added the accepted label Aug 8, 2022
@llbartekll llbartekll requested a review from sekimondre August 8, 2022 10:41
sekimondre
sekimondre suggested changes Aug 8, 2022
View reviewed changes
Copy link

@sekimondre sekimondre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the release PR is lacking the version bump in user agent.

@llbartekll
Copy link
Contributor Author

@MisterVants good catch. how we can automate it ?🤔

@llbartekll llbartekll requested a review from sekimondre August 8, 2022 12:22
@sekimondre
Copy link

@MisterVants good catch. how we can automate it ?🤔

Good question, I don't know. Is it possible to make a CI check that tries to match the release name with the user agent info? That could raise an error on the PR, at least.

@llbartekll llbartekll merged commit 8dda02c into main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flypaper0 flypaper0 flypaper0 approved these changes

@sekimondre sekimondre sekimondre approved these changes

Assignees
No one assigned
Labels
accepted
Projects
Swift SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llbartekll @sekimondre @flypaper0 @arein