Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network] #364: Change relay methods prefix from "iridium" to "irn" #402

Merged
merged 3 commits into from
Aug 4, 2022
Merged

[Network] #364: Change relay methods prefix from "iridium" to "irn" #402

merged 3 commits into from
Aug 4, 2022

Conversation

sekimondre
Copy link

#closes 364

Self-explanatory

@sekimondre sekimondre self-assigned this Aug 3, 2022
@arein arein added the accepted label Aug 3, 2022
llbartekll
llbartekll requested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change relay protocol options for irn as well. so uri do not contain legacy naming

@sekimondre sekimondre requested a review from llbartekll August 4, 2022 16:20
@sekimondre
Copy link
Author

@llbartekll some changes included storage IDs, do you think it can cause any problems?

llbartekll
llbartekll reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that changing storage identifier will break existing integrations. Can you manually test it?

@sekimondre
Copy link
Author

I think we can just leave as it is, it's well isolated and won't affect the protocol

@sekimondre sekimondre requested a review from llbartekll August 4, 2022 16:27
@sekimondre sekimondre merged commit 4de1c3e into develop Aug 4, 2022
@sekimondre sekimondre deleted the feature/#364-replace-iridium-to-irn branch August 4, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flypaper0 flypaper0 flypaper0 approved these changes

@llbartekll llbartekll llbartekll approved these changes

Assignees

@sekimondre sekimondre

Labels
accepted protocol
Projects
Swift SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sekimondre @flypaper0 @llbartekll @arein