#347 extend pairing on approve proposal #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
reviewed
Jul 28, 2022
| try await networkingInteractor.respond(topic: payload.topic, response: .response(response), tag: payload.wcRequest.responseTag) | ||
|
|
||
| try pairing.updateExpiry() |
There was a problem hiding this comment.
we also extending pairing in handleProposeResponse. So in approve method we extending for wallet, and in handleProposeResponse we extending for dapp, right?
flypaper0
reviewed
Jul 28, 2022
| @@ -82,7 +81,15 @@ final class ApproveEngine { | |||
| let proposeResponse = SessionType.ProposeResponse(relay: relay, responderPublicKey: selfPublicKey.hexRepresentation) | |||
| let response = JSONRPCResponse<AnyCodable>(id: payload.wcRequest.id, result: AnyCodable(proposeResponse)) | |||
|
|
|||
| guard var pairing = pairingStore.getPairing(forTopic: payload.topic) else { | |||
There was a problem hiding this comment.
do we care about pairing is active / inactive ?
There was a problem hiding this comment.
I think on wallet pairing is always active
flypaper0
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend pairing on every approve proposal on wallet