#248 fix crash on pair #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
llbartekll
commented
Jul 26, 2022
llbartekll
commented
- fix crash on pair but does not override key in keychain close Fix potential crash on malformed QR code scan #248
- sync develop with main
feat: reorders the ci steps to decrease ci time
flypaper0
approved these changes
Jul 26, 2022
| let symKey = try! SymmetricKey(hex: uri.symKey) // FIXME: Malformed QR code from external source can crash the SDK | ||
| try! kms.setSymmetricKey(symKey, for: pairing.topic) | ||
| let symKey = try SymmetricKey(hex: uri.symKey) | ||
| try kms.setSymmetricKey(symKey, for: pairing.topic) |
There was a problem hiding this comment.
we still need key replacement logic, right?
There was a problem hiding this comment.
correct,
it's this one:
#360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.