[Chat] sync chat sdk with kotlin implementation and add reject method #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
llbartekll
commented
Jul 12, 2022
•
llbartekll
commented
- sync chat sdk with kotlin implementation:
- rpc methods property names and structure
- timestamp format
- rpc methods serialisation
- add reject method
…V2 into chat-reject # Conflicts: # Example/IntegrationTests/Chat/ChatTests.swift # Sources/Chat/ProtocolServices/Invitee/InvitationHandlingService.swift # Sources/Chat/Types/InviteParams.swift
llbartekll
changed the title
flypaper0
approved these changes
Jul 12, 2022
|
|
||
| class LeaveService { | ||
| func leave(topic: String) { | ||
|
|
| @@ -52,7 +53,8 @@ class MessagingService { | |||
| private func setUpRequestHandling() { | |||
| networkingInteractor.requestPublisher.sink { [unowned self] subscriptionPayload in | |||
| switch subscriptionPayload.request.params { | |||
| case .message(let message): | |||
| case .message(var message): | |||
| message.topic = subscriptionPayload.topic | |||
There was a problem hiding this comment.
Why we need to do that? Is it possible to avoid struct mutation?
There was a problem hiding this comment.
wc_chatMessage does not contain topic but when we query messages from storage it is convenient to distinguish them by topic.
maybe some storage improvement could allow to avoid this but instant sync with kotlin was a priority
will take this into consideration in next storage PR
|
|
||
| try await networkingInteractor.respond(topic: responseTopic, response: response) | ||
|
|
||
| invitePayloadStore.delete(forKey: inviteId) |
There was a problem hiding this comment.
gj, need to do the same for approve
| @@ -67,7 +69,7 @@ class InviteService { | |||
| let inviteResponse = try jsonrpc.result.get(InviteResponse.self) | |||
| logger.debug("Invite has been accepted") | |||
| guard case .invite(let inviteParams) = response.requestParams else { return } | |||
| Task { try await createThread(selfPubKeyHex: inviteParams.pubKey, peerPubKey: inviteResponse.pubKey, account: inviteParams.account, peerAccount: peerAccount)} | |||
| Task { try await createThread(selfPubKeyHex: inviteParams.publicKey, peerPubKey: inviteResponse.publicKey, account: inviteParams.account, peerAccount: peerAccount)} | |||
There was a problem hiding this comment.
let's use priority .background everywhere?
| } else { | ||
| throw Errors.decoding | ||
| } | ||
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.