Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] #248 Handle malformed QR code #293

Closed
wants to merge 2 commits into from
Closed

[WIP] #248 Handle malformed QR code #293

wants to merge 2 commits into from

Conversation

MaisaMilena
Copy link
Contributor

@MaisaMilena MaisaMilena commented Jun 24, 2022 •
edited
Loading

Overview

Try to fix potential crash when scanning malformed QR Code

Changes

  • Handle forced SymmetricKey generation with a do...catch
  • Add error related to subscribe function (does it make sense?)

Notes

  • I'm not able to test scanning a QR code on a physical device
  • I couldn't figure out what is a malformed QR Code and how to test it. Everything I created as a WalletConnectURI (parameter of the function pair) doesn't throw an error. Am I missing something?

@MaisaMilena MaisaMilena changed the title #248 Handle malformed QR code [WIP] #248 Handle malformed QR code Jun 24, 2022
@llbartekll llbartekll deleted the branch WalletConnect:develop July 5, 2022 05:25
@llbartekll llbartekll closed this Jul 5, 2022
sekimondre pushed a commit that referenced this pull request Jul 8, 2022
Merge pull request #317 from WalletConnect/feature/chat-sample-homesc…
14d204b 
…reen-#293

[Chat] Showcase app UI #293
@flypaper0 flypaper0 mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaisaMilena @llbartekll