-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Commons and Toolbox packages #155
Conversation
#8 extend method
Co-authored-by: André Vants <[email protected]>
#139 update changes
#139 update methods
#18 Pairing expiry tests
@MisterVants I think we can create readme for each package and add your guidelines from PR there. |
TODO: Test usage of sub-package types with a single (needs to be done before following up with the new structure) |
TODO: Rename |
Solution 1: Use typealiases to expose sub-package public types. A list can be maintained in a single file. |
Commons package added in PR #256, together with JSONRPC package. TestingUtils to be renamed to Toolbox later. |
Introduces 2 base dependency packages: Commons and Toolbox, and extract some common code to them. They are base dependencies for the SDK and the tests target. We could follow some guidelines for these packages to help maintaining the health of the project on the long term.
Commons:
AnyCodable
).Toolbox:
Notes:
Either
type was re-introduced, it will help build a full JSON-RPC compliant API for requests.