Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notify] Subscriptions watcher #1142

Merged
merged 11 commits into from
Sep 29, 2023
Merged

[Notify] Subscriptions watcher #1142

merged 11 commits into from
Sep 29, 2023

Conversation

llbartekll
Copy link
Contributor

Description

  • Triggers notify watch subscription request every 5 minutes
  • Sets up timer

Resolves # (issue)

How Has This Been Tested?

  • manually
  • unit tests

Due Dilligence

  • Breaking change
  • Requires a documentation update

@llbartekll llbartekll temporarily deployed to internal September 27, 2023 10:48 — with GitHub Actions Inactive
@llbartekll llbartekll marked this pull request as draft September 27, 2023 10:55
@llbartekll llbartekll temporarily deployed to internal September 27, 2023 11:05 — with GitHub Actions Inactive
@llbartekll llbartekll marked this pull request as ready for review September 27, 2023 11:08
@llbartekll llbartekll temporarily deployed to internal September 27, 2023 11:15 — with GitHub Actions Inactive
@llbartekll llbartekll marked this pull request as draft September 27, 2023 11:20
@llbartekll llbartekll temporarily deployed to internal September 27, 2023 11:54 — with GitHub Actions Inactive
@llbartekll llbartekll marked this pull request as ready for review September 27, 2023 11:54
@llbartekll llbartekll marked this pull request as draft September 29, 2023 10:19
@llbartekll llbartekll temporarily deployed to internal September 29, 2023 11:26 — with GitHub Actions Inactive
…V2 into subscriptions-watcher

# Conflicts:
#	Example/ExampleApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@llbartekll llbartekll temporarily deployed to internal September 29, 2023 11:27 — with GitHub Actions Inactive
@llbartekll llbartekll marked this pull request as ready for review September 29, 2023 11:28
func watchSubscriptions() {
watchSubscriptionsWorkItem?.cancel()

let workItem = DispatchWorkItem { [weak self] in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👍

@llbartekll llbartekll merged commit 62f5701 into develop Sep 29, 2023
@llbartekll llbartekll deleted the subscriptions-watcher branch September 29, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants